Kristian Rietveld [Sat, 24 Oct 2009 10:25:55 +0000 (12:25 +0200)]
Use screen when emitting signal, not _gdk_screen
Kristian Rietveld [Sat, 24 Oct 2009 10:25:29 +0000 (12:25 +0200)]
Emit monitors-changed signal when appropriate
Kristian Rietveld [Sat, 24 Oct 2009 09:51:51 +0000 (11:51 +0200)]
Move screen resolution setup to GdkScreenQuartz initializer
Kristian Rietveld [Sat, 24 Oct 2009 09:48:39 +0000 (11:48 +0200)]
Create a proper subclass of GdkScreen: GdkScreenQuartz
Kristian Rietveld [Sat, 24 Oct 2009 08:29:43 +0000 (10:29 +0200)]
Register and handle a display reconfiguration callback
Using this we can update our internal monitor/screen layout state
and emit the GdkScreen::size-changed signal. Work has not
completely finished on this yet, see bug 596238.
Kristian Rietveld [Mon, 12 Oct 2009 07:55:45 +0000 (09:55 +0200)]
Setup monitor rects during screen initialization and re-use data
Kristian Rietveld [Wed, 7 Oct 2009 16:54:47 +0000 (18:54 +0200)]
Move screen initialization to gdkscreen-quartz.c
Matthias Clasen [Mon, 26 Oct 2009 03:47:59 +0000 (23:47 -0400)]
Fix issues with symbolic colors in rc file parsing
Don't recreate the settings color hash every time, repopulate it
instead. This avoids invalidating the references held by RcContexts.
Matthias Clasen [Mon, 26 Oct 2009 03:46:27 +0000 (23:46 -0400)]
Fixes for the compose-parse.py script
Several fixes by Ray Strode and Peter Hutterer to make compose-parse.py
work with the current X.org Compose file.
Matthias Clasen [Mon, 26 Oct 2009 03:42:58 +0000 (23:42 -0400)]
Update compose sequences
This patch includes additions to the X.org Compose file from the
last year. Patch by Peter Hutterer
Kevin Peng [Sun, 25 Oct 2009 21:03:19 +0000 (22:03 +0100)]
GdkPixbuf loader for QTIF format
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=366217
Yevgen Muntyan [Sun, 25 Oct 2009 22:46:19 +0000 (23:46 +0100)]
Use standard mac shortcuts
This changes Ctrl-X, Ctrl-C, etc. to Cmd-X, Cmd-C, etc. Also,
Alt-Left and Alt-Right in text widgets bound to Ctrl-Left and
Ctrl-Right actions
https://bugzilla.gnome.org/show_bug.cgi?id=530351
Javier Jardón [Sat, 24 Oct 2009 15:09:01 +0000 (17:09 +0200)]
Cast to gchar* to fix a compilation warning
Michael Emmel [Sat, 24 Oct 2009 15:17:06 +0000 (17:17 +0200)]
Fix for position bug
https://bugzilla.gnome.org/show_bug.cgi?id=590800
Matthew Barnes [Fri, 23 Oct 2009 23:32:25 +0000 (19:32 -0400)]
Bug 581150 - GtkIconView tries to paint items with invalid sizes
Run gtk_icon_view_layout() if necessary before attempting to paint the
icon view items during an expose event. This ensures all the items have
valid sizes, as some themes don't take kindly to negative dimensions.
Kristian Rietveld [Fri, 23 Oct 2009 11:53:57 +0000 (13:53 +0200)]
Bug 598881 - Unimplemented GdkWindowImplIface methods crash gimp on OSX
Add dummy for _gdk_input_window_crossing (). Set both input_window_destroy
and input_window_crossing pointers in the Impl struct.
Reported by John Ralls.
Tor Lillqvist [Fri, 23 Oct 2009 10:40:27 +0000 (13:40 +0300)]
Use correct type text/uri-list for the dropped files selection
Fixes bug #599321.
Javier Jardón [Wed, 21 Oct 2009 22:00:52 +0000 (00:00 +0200)]
Cast to gchar* to fix a compilation warning
Javier Jardón [Wed, 21 Oct 2009 21:53:01 +0000 (23:53 +0200)]
Cast to fix compilation warning
Luca Ferretti [Wed, 21 Oct 2009 20:06:14 +0000 (22:06 +0200)]
Add translators comments for tab labels (closes 599118)
Luca Ferretti [Wed, 21 Oct 2009 19:47:06 +0000 (21:47 +0200)]
Minor fixes
Javier Jardon [Wed, 21 Oct 2009 18:46:44 +0000 (21:46 +0300)]
Use G_STRLOC instead __FILE__ and __LINE__
Patch from bug #599225
Michael Natterer [Wed, 21 Oct 2009 18:21:20 +0000 (20:21 +0200)]
Add single-include guard and reduce includes to what's needed
Michael Natterer [Wed, 21 Oct 2009 18:20:54 +0000 (20:20 +0200)]
Don't allow to include this new header individually
Javier Jardón [Wed, 21 Oct 2009 17:41:50 +0000 (19:41 +0200)]
Fix a compilation warning: use NULL instead ""
Javier Jardón [Wed, 21 Oct 2009 03:33:58 +0000 (05:33 +0200)]
Remove unused function
Javier Jardón [Wed, 21 Oct 2009 03:19:39 +0000 (05:19 +0200)]
Fix compilation warnings: use G_GSIZE_FORMAT instead %i
Federico Mena Quintero [Wed, 21 Oct 2009 17:29:03 +0000 (12:29 -0500)]
bgo#563010 - Fix clearing the selection in GtkFileChooserButton
Previously the filename would get re-set on the button if one cleared the selection,
as an async cancellable was not getting canceled in that case.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Cody Russell [Wed, 21 Oct 2009 16:40:19 +0000 (18:40 +0200)]
Added editing_canceled property to GtkCellEditable
GTK_ENTRY()->editing_canceled should really have been a parameter of the
GtkCellEditable::editing-done signal, it should be a property on the cell
editable interface
https://bugzilla.gnome.org/show_bug.cgi?id=594962
Christian Dywan [Wed, 21 Oct 2009 16:25:02 +0000 (18:25 +0200)]
Deprecated GtkNotebook tab packing
https://bugzilla.gnome.org/show_bug.cgi?id=596083
Christian Dywan [Wed, 21 Oct 2009 16:15:52 +0000 (18:15 +0200)]
Deprecate GtkCurve and GtkGammaCurve
https://bugzilla.gnome.org/show_bug.cgi?id=556263
Christian Dywan [Wed, 21 Oct 2009 16:12:01 +0000 (18:12 +0200)]
Added accesor for GTK_VIEWPORT (widget)->bin_window
Although, you can use:
gtk_widget_get_parent_window (gtk_bin_get_child (GTK_BIN (widget)))
there already are gtk_tree_view_get_bin_window() and
gtk_layout_get_bin_window() in GTK+ api.
https://bugzilla.gnome.org/show_bug.cgi?id=594960
Javier Jardón [Wed, 21 Oct 2009 00:55:46 +0000 (02:55 +0200)]
Fix a compilation warning
Use switch instead if's to get a default value
Javier Jardón [Tue, 20 Oct 2009 02:08:00 +0000 (04:08 +0200)]
Fix a compilation warning
Reorder the function so the "lookup_context" variable can't be
used uninitialized
Javier Jardón [Wed, 21 Oct 2009 00:37:05 +0000 (02:37 +0200)]
Fix some compilation warning
Complete the previous patch: set lower to 0 too
Javier Jardón [Wed, 21 Oct 2009 00:07:26 +0000 (02:07 +0200)]
Fix some compilation warning
Added some default cases and assert if reached
Javier Jardón [Tue, 20 Oct 2009 02:06:05 +0000 (04:06 +0200)]
Fix a compilation warning
Use parenthesis in a expression with "&" operator
Javier Jardón [Tue, 20 Oct 2009 18:43:44 +0000 (20:43 +0200)]
Fix a compilation warning
Catch the returned value of write()
Javier Jardón [Tue, 20 Oct 2009 02:01:52 +0000 (04:01 +0200)]
Fix compilation warning
Use g_get_current_dir() instead getcwd()
Javier Jardón [Tue, 20 Oct 2009 02:00:02 +0000 (04:00 +0200)]
Remove some unnused variables
Marek Kasik [Mon, 19 Oct 2009 09:44:09 +0000 (11:44 +0200)]
A small correction of previous commit
Correct of a typo.
Matthias Clasen [Mon, 19 Oct 2009 00:38:28 +0000 (20:38 -0400)]
Correct a small oversight
When changing themes, we also need to update the box spacing of
tooltips.
Tor Lillqvist [Sun, 18 Oct 2009 11:35:17 +0000 (14:35 +0300)]
Use correct size for root window with multiple monitors
The root window width and height have already been correctly
initialised in _gdk_root_window_size_init() to cover all monitors, so
don't incorrectly re-initialise using GetSystemMetrics(SM_C[XY]SCREEN)
which only gives the size of the primary monitor anyway. (See MSDN.)
This fixes at least gdk_screen_get_{width,height}() which indirectly
affects at least the positioning of combo box pop-up menus on multiple
monitors.
Tor Lillqvist [Sun, 18 Oct 2009 11:19:55 +0000 (14:19 +0300)]
Delete a couple of leftover commented-out lines
Tor Lillqvist [Sun, 18 Oct 2009 11:19:24 +0000 (14:19 +0300)]
Add missing newline to debugging output
Tor Lillqvist [Sun, 18 Oct 2009 09:08:18 +0000 (12:08 +0300)]
Delete unused leftover static function
Tor Lillqvist [Sun, 18 Oct 2009 09:06:29 +0000 (12:06 +0300)]
More meaningful debugging output in gdk_win32_window_get_root_coords
Tor Lillqvist [Sun, 18 Oct 2009 08:51:57 +0000 (11:51 +0300)]
Remove unused variables and static functions
Tor Lillqvist [Sun, 18 Oct 2009 08:43:33 +0000 (11:43 +0300)]
Correct function names in debugging output
Matthias Clasen [Sun, 18 Oct 2009 06:07:58 +0000 (02:07 -0400)]
Don't omit GTK_ICON_SIZE_DIALOG
Matthias Clasen [Sun, 18 Oct 2009 05:36:14 +0000 (01:36 -0400)]
Fix a problem in GtkImage size allocation
When GtkMisc padding is set on an image, the optimization for only
recalculating size after a clear() breaks, since the requisition is
not (0, 0). We need a separate 'need_calc' flag.
Simos Xenitellis [Sat, 17 Oct 2009 14:30:28 +0000 (17:30 +0300)]
Updated Greek translation
Jorge González [Sat, 17 Oct 2009 11:45:01 +0000 (13:45 +0200)]
Updated Spanish translation
Christian Dywan [Fri, 16 Oct 2009 16:45:53 +0000 (18:45 +0200)]
Undefine GTK_DISABLE_DEPRECATED in testinput to keep it compiling
Christian Dywan [Fri, 16 Oct 2009 14:05:13 +0000 (16:05 +0200)]
Deprecate GtkInputDialog
Deprecate the widget and adjust the documentation.
https://bugzilla.gnome.org/show_bug.cgi?id=594903
Tor Lillqvist [Fri, 16 Oct 2009 10:29:54 +0000 (13:29 +0300)]
Fix build on Windows
Debarshi Ray [Thu, 15 Oct 2009 21:22:20 +0000 (00:22 +0300)]
Use G_BEGIN/END_DECLS in gtkcellrendererspinner.h
Federico Mena Quintero [Wed, 30 Sep 2009 23:49:33 +0000 (18:49 -0500)]
Fix thinkos in which fields get used
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Wed, 30 Sep 2009 23:39:33 +0000 (18:39 -0500)]
Oops, it's gsize, not GSize
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Wed, 30 Sep 2009 22:55:12 +0000 (17:55 -0500)]
Fix a g_strdup_printf()
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 11 Sep 2009 19:28:36 +0000 (14:28 -0500)]
Put the list of column types in a macro
Every call to _gtk_file_system_model_new*() gets the same list of column types,
so we now keep the list in a macro instead of having duplicated copies all around.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 11 Sep 2009 19:20:19 +0000 (14:20 -0500)]
Clarify the arguments of g_file_query_info_async()
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 11 Sep 2009 18:32:08 +0000 (13:32 -0500)]
Make copy_attribute() a function instead of a macro
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 11 Sep 2009 18:25:29 +0000 (13:25 -0500)]
Don't leak a treepath if the treeview is not populated yet
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 11 Sep 2009 18:14:49 +0000 (13:14 -0500)]
Factor out function to set a fixed size for the icon cell renderers
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 11 Sep 2009 18:08:11 +0000 (13:08 -0500)]
Comment that the column order needs to be kept in sync across two functions
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 11 Sep 2009 18:03:34 +0000 (13:03 -0500)]
Fix typo in a comment
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 11 Sep 2009 17:44:21 +0000 (12:44 -0500)]
Make get_selected_file() return a ref'ed file
The old semantics was to return a GFile* owned by the file system model; the new
semantics is to hand out new references whenever possible.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Thu, 10 Sep 2009 22:22:12 +0000 (17:22 -0500)]
In set_filter(), handle the case where the new filter is the same as the old filter
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Thu, 10 Sep 2009 21:33:37 +0000 (16:33 -0500)]
s/get_is_visible/iter_is_visible for clarity
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Thu, 10 Sep 2009 20:36:15 +0000 (15:36 -0500)]
Remove obsolete comment
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 4 Sep 2009 18:53:46 +0000 (13:53 -0500)]
Make the code match the docs in _gtk_file_system_model_clear_cache()
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 4 Sep 2009 18:42:46 +0000 (13:42 -0500)]
Free some missing fields in ::finalize()
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 4 Sep 2009 18:06:54 +0000 (13:06 -0500)]
Clarify variable names in gtk_file_system_model_sort()
To comply with the i -> indexes; r -> rows convention.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 4 Sep 2009 17:49:53 +0000 (12:49 -0500)]
Nothing to do for ref/unref_node
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 4 Sep 2009 17:31:37 +0000 (12:31 -0500)]
Clarify a couple of spots with comments
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Fri, 4 Sep 2009 17:01:16 +0000 (12:01 -0500)]
Clarify array indexes vs. row numbers
There was some confusion between "index" as used for the model->files[] array,
and node->index as used for our 1-based row numbers. Now we use "index" only
for indices in the model->files[] array, and node->row for row numbers. Functions
and variables are renamed to clarify whether they refer to indexes or rows.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Thu, 3 Sep 2009 23:22:21 +0000 (18:22 -0500)]
Big comment on how GtkFileSystemModel works
Let's have some documentation on the idea behind this beast...
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Thu, 3 Sep 2009 17:09:09 +0000 (12:09 -0500)]
Remove obsolete code to use a cached mime-type
The non-standard "filechooser::mime-type" was a remnant of the recent-files code using
a hand-built GFileInfo; now we just query the file info ourselves.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Wed, 2 Sep 2009 23:26:00 +0000 (18:26 -0500)]
Fix thinko in node_should_be_visible()
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Wed, 2 Sep 2009 22:10:46 +0000 (17:10 -0500)]
Factory out functions to emit row_inserted, row_changed, row_deleted
This is to avoid temporary variables for the path/iter and to avoid duplicated code.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Wed, 2 Sep 2009 20:23:21 +0000 (15:23 -0500)]
When updating a file, handle the case where the old file info is the same as the new one
This prevents us from inadvertently losing the last ref to the info.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Wed, 2 Sep 2009 20:21:45 +0000 (15:21 -0500)]
When removing a file, also remove it from the file_lookup hash table
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Wed, 2 Sep 2009 19:51:02 +0000 (14:51 -0500)]
Comment on how the file_lookup hash table gets rebuilt on demand
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Wed, 2 Sep 2009 18:54:52 +0000 (13:54 -0500)]
Clarify the arguments to g_file_query_info_async()
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Wed, 2 Sep 2009 18:43:03 +0000 (13:43 -0500)]
Show an error dialog when we can't read the folder's contents
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Mon, 31 Aug 2009 21:13:05 +0000 (16:13 -0500)]
Clarify the code flow in gtk_file_system_model_got_files()
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Mon, 31 Aug 2009 20:53:45 +0000 (15:53 -0500)]
Remove the dir_thaw_source while disposing the model
Otherwise that timeout may trigger after the model has died.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Mon, 31 Aug 2009 20:11:44 +0000 (15:11 -0500)]
Make _gtk_file_system_model_remove_file() static
It was only used internally by the model.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Mon, 31 Aug 2009 20:08:43 +0000 (15:08 -0500)]
Make _gtk_file_system_model_add_file() static
It was only used internally by the model, anyway.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Thu, 27 Aug 2009 00:27:40 +0000 (19:27 -0500)]
Clarify the comments that some fields in GtkFileSystemModel can be NULL
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Thu, 27 Aug 2009 00:25:18 +0000 (19:25 -0500)]
Clarify the arguments to g_file_monitor_directory()
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Thu, 27 Aug 2009 00:14:07 +0000 (19:14 -0500)]
Clarify an argument to g_file_enumerate_children_async()
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Thu, 27 Aug 2009 00:10:51 +0000 (19:10 -0500)]
Fix and tighten an assertion
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Thu, 27 Aug 2009 00:10:26 +0000 (19:10 -0500)]
Complete the documentation string for _gtk_file_system_model_new()
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Wed, 26 Aug 2009 23:52:24 +0000 (18:52 -0500)]
Start with a file array with a resonable preallocated size
g_array_new() doesn't reserve any size by default, so during the initial population
of the file array, we'll do more reallocs than strictly needed. We'll start with
a reasonable preallocated size, in this case the number of files which we can
get in a single chunk out of GIO.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Wed, 26 Aug 2009 23:42:49 +0000 (18:42 -0500)]
Compute the node size only once to avoid the scary macro
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Wed, 26 Aug 2009 23:38:03 +0000 (18:38 -0500)]
g_error() as soon as we catch an invalid column type
There's no point in running a GtkFileSystemModel with invalid column types.
This way we can also avoid clearing the memory of the column_types array.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Benjamin Otte [Wed, 1 Jul 2009 08:32:26 +0000 (10:32 +0200)]
Improve show_and_select_files() function
The previous function enumerated the whole directory and used a lot of
outdated API to decide how to show files.
The new code queries the filesystem model to decide about this.
The now unused old functions were removed.
Benjamin Otte [Thu, 25 Jun 2009 13:05:27 +0000 (15:05 +0200)]
Remove unused error argument from show_and_select_files()